Replace simple mssql_input_sql_file with pre and post variables
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `mssql_input_sql_file` input SQL files at the end of the role invocation. However, users must input some SQL files at the beginning of the role before it applies any configuration to SQL Server. `mssql_pre_input_sql_file` and `mssql_post_input_sql_file` has been added to address this functionality.
|
[citest pending] |
richm
reviewed
Aug 3, 2022
richm
reviewed
Aug 3, 2022
| - name: Link the deprecated mssql_input_sql_file fact | ||
| set_fact: | ||
| mssql_input_sql_file: "{{ mssql_input_sql_file }}" | ||
| when: mssql_input_sql_file is defined |
There was a problem hiding this comment.
This is a typo, my intention was to set mssql_post_input_sql_file: "{{ mssql_input_sql_file }}" so that the mssql_input_sql_file variable that somebody might have in old playbooks work. Fixed. I've also added a debug module above to print a deprecated warning.
spetrosi
force-pushed
the
pre-post-sql-scripts
branch
from
68c8d6c
to
1cf2414
Compare
|
[citest pending] |
richm
reviewed
Aug 5, 2022
| "The accept_microsoft_sql_server_2019_standard_eula variable is | ||
| deprecated and will be removed in a future version. Edit your playbook | ||
| to use the mssql_accept_microsoft_sql_server_standard_eula variable | ||
| instead." |
There was a problem hiding this comment.
If you are using the yaml string > or | (with and without the - modifier) you do not have to quote the string.
There was a problem hiding this comment.
Good to know, I've opened #86 for this and will fix all occurrences in one go as I have many of them throughout the role.
richm
approved these changes
Aug 5, 2022
spetrosi
added a commit
to spetrosi/mssql
that referenced
this pull request
Aug 23, 2022
[1.2.1] - 2022-08-23 -------------------- ### New Features - Use firewall role to configure firewall for SQL Server (linux-system-roles#77) - Add `mssql_firewall_configure` that controls whether to manage firewall ports. - If set to `true`, the role opens the TCP port provided with `mssql_tcp_port` and if applicable closes the previously opened port. - Replace simple `mssql_input_sql_file` with `pre` and `post` variables (linux-system-roles#84) - Previously, `mssql_input_sql_file` input SQL files at the end of the role invocation. However, users must input some SQL files at the beginning of the role before it applies any configuration to SQL Server. `mssql_pre_input_sql_file` and `mssql_post_input_sql_file` has been added to address this functionality. - Replace agents in cluster configuration with watchdog (linux-system-roles#83) - Change bare-metal HA example in README to use watchdog instead of agents - Unify vars in README and tests_configure_ha_cluster - tests_configure_ha_cluster - move variables to the top for readability - Add prerequisite about DNS resolution to README (linux-system-roles#87) - README: Note that changing HA listener port number is not supported (linux-system-roles#91) - Add a prerequisites section for HA. (linux-system-roles#96) - Add mssql_ha_virtual_ip (linux-system-roles#92) - Fix vars indentation in the example playbook - Add mssql_ha_virtual_ip - Add listeners to the availability group - Add tests for the new template - Update examples in README - In Azure example playbook add firewall role invocation and comments - Describe the requirement to define ha_cluster's names with short names - Note that witness can be set for max 1 host ### Bug Fixes - Remove unnecessary quotes from yaml strings (linux-system-roles#88) - Remove tasks that verify HA setup (linux-system-roles#93) - When running against VMs in beaker, the verification tasks failed because db replication requires more time. It's safer to remove verification tasks completely and leave verification on users - s/System Roles role/fedora.linux_system_roles.role/ to avoid ambiguity (linux-system-roles#94) - README: fix URLs and xrefs markup (linux-system-roles#97) - Sort ansible_play_hosts to ensure configure_ag script runs smoothly (linux-system-roles#98) - Remove the workaround for `any_errors_fatal: true` (linux-system-roles#100) - Previously, the role would use a workaround of setting a __mssql_primary_successful variable to define whether the primary node really failed or not. This was required because any_errors_fatal: true would not work when run in a block where rescue or always block would execute. This workaround creates troubles when the order of hosts in inventory is not primary-secondary-witness - the role skips a rescue block after failing tasks in the block on primary and goes to the next block. Removing the workardound for stability. Certificate and private key now won't be removed from the control node in the case of failure, but those files will be removed on a next successful role invocation. ### Other Changes - Remove the tests/vars symlink for vars (linux-system-roles#78) - ansible-test returns ERROR: tests/mssql/vars:0:0: broken symlinks are not allowed See documentation for help: https://docs.ansible.com/ansible-core/2.12/dev_guide/testing/sanity/symlinks.html - Use GITHUB_REF_NAME as name of push branch; fix error in branch detection [citest skip] - We need to get the name of the branch to which CHANGELOG.md was pushed. For now, it looks as though `GITHUB_REF_NAME` is that name. But don't trust it - first, check that it is `main` or `master`. If not, then use a couple of other methods to determine what is the push branch. Signed-off-by: Rich Megginson <rmeggins@redhat.com> - tests_tls: generate certs on managed nodes to avoid installing local RPM (linux-system-roles#82) - Do not publish legacy role format to galaxy, mssql only has a collection (linux-system-roles#89) - [citest skip] tox-lsr 2.13.0; check-meta-versions (linux-system-roles#90) - Update to tox-lsr 2.13.0 - this adds check-meta-versions to py310 Signed-off-by: Rich Megginson <rmeggins@redhat.com> Signed-off-by: Sergei Petrosian <spetrosi@redhat.com>
spetrosi
added a commit
that referenced
this pull request
Aug 23, 2022
[1.2.1] - 2022-08-23 -------------------- ### New Features - Use firewall role to configure firewall for SQL Server (#77) - Add `mssql_firewall_configure` that controls whether to manage firewall ports. - If set to `true`, the role opens the TCP port provided with `mssql_tcp_port` and if applicable closes the previously opened port. - Replace simple `mssql_input_sql_file` with `pre` and `post` variables (#84) - Previously, `mssql_input_sql_file` input SQL files at the end of the role invocation. However, users must input some SQL files at the beginning of the role before it applies any configuration to SQL Server. `mssql_pre_input_sql_file` and `mssql_post_input_sql_file` has been added to address this functionality. - Replace agents in cluster configuration with watchdog (#83) - Change bare-metal HA example in README to use watchdog instead of agents - Unify vars in README and tests_configure_ha_cluster - tests_configure_ha_cluster - move variables to the top for readability - Add prerequisite about DNS resolution to README (#87) - README: Note that changing HA listener port number is not supported (#91) - Add a prerequisites section for HA. (#96) - Add mssql_ha_virtual_ip (#92) - Fix vars indentation in the example playbook - Add mssql_ha_virtual_ip - Add listeners to the availability group - Add tests for the new template - Update examples in README - In Azure example playbook add firewall role invocation and comments - Describe the requirement to define ha_cluster's names with short names - Note that witness can be set for max 1 host ### Bug Fixes - Remove unnecessary quotes from yaml strings (#88) - Remove tasks that verify HA setup (#93) - When running against VMs in beaker, the verification tasks failed because db replication requires more time. It's safer to remove verification tasks completely and leave verification on users - s/System Roles role/fedora.linux_system_roles.role/ to avoid ambiguity (#94) - README: fix URLs and xrefs markup (#97) - Sort ansible_play_hosts to ensure configure_ag script runs smoothly (#98) - Remove the workaround for `any_errors_fatal: true` (#100) - Previously, the role would use a workaround of setting a __mssql_primary_successful variable to define whether the primary node really failed or not. This was required because any_errors_fatal: true would not work when run in a block where rescue or always block would execute. This workaround creates troubles when the order of hosts in inventory is not primary-secondary-witness - the role skips a rescue block after failing tasks in the block on primary and goes to the next block. Removing the workardound for stability. Certificate and private key now won't be removed from the control node in the case of failure, but those files will be removed on a next successful role invocation. ### Other Changes - Remove the tests/vars symlink for vars (#78) - ansible-test returns ERROR: tests/mssql/vars:0:0: broken symlinks are not allowed See documentation for help: https://docs.ansible.com/ansible-core/2.12/dev_guide/testing/sanity/symlinks.html - Use GITHUB_REF_NAME as name of push branch; fix error in branch detection [citest skip] - We need to get the name of the branch to which CHANGELOG.md was pushed. For now, it looks as though `GITHUB_REF_NAME` is that name. But don't trust it - first, check that it is `main` or `master`. If not, then use a couple of other methods to determine what is the push branch. Signed-off-by: Rich Megginson <rmeggins@redhat.com> - tests_tls: generate certs on managed nodes to avoid installing local RPM (#82) - Do not publish legacy role format to galaxy, mssql only has a collection (#89) - [citest skip] tox-lsr 2.13.0; check-meta-versions (#90) - Update to tox-lsr 2.13.0 - this adds check-meta-versions to py310 Signed-off-by: Rich Megginson <rmeggins@redhat.com> Signed-off-by: Sergei Petrosian <spetrosi@redhat.com> Signed-off-by: Sergei Petrosian <spetrosi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
mssql_input_sql_fileinput SQL files at the end of therole invocation. However, users must input some SQL files at the
beginning of the role before it applies any configuration to SQL Server.
mssql_pre_input_sql_fileandmssql_post_input_sql_filehas beenadded to address this functionality.