Critical Error in Idempotence Test When Setting Custom Port for Tangd #138
Comments
|
I think the issue is that the role uses the global variable |
richm
added a commit
to richm/linux-system-roles-nbde_server
that referenced
this issue
Feb 14, 2024
…he role Cause: The role was assuming that the only file being managed in the tangd socket override directory was the override.conf file for the custom port. Consequence: The role would delete the directory if there was no custom port without checking if there were other files in that directory being used to override tangd settings. This would cause the directory to be recreated upon subsequent runs, and the role would report a change, and not appear to be idempotent. Fix: When adding the override directory for the port override file, do not change its attributes. Do not delete the directory if there are other files in it. Result: The role will co-exist with the tangd socket override files being managed outside of the role. Signed-off-by: Rich Megginson <rmeggins@redhat.com> Fixes linux-system-roles#138
richm
added a commit
to richm/linux-system-roles-nbde_server
that referenced
this issue
Feb 14, 2024
…he role Cause: The role was assuming that the only file being managed in the tangd socket override directory was the override.conf file for the custom port. Consequence: The role would delete the directory if there was no custom port without checking if there were other files in that directory being used to override tangd settings. This would cause the directory to be recreated upon subsequent runs, and the role would report a change, and not appear to be idempotent. Fix: When adding the override directory for the port override file, do not change its attributes. Do not delete the directory if there are other files in it. Result: The role will co-exist with the tangd socket override files being managed outside of the role. Signed-off-by: Rich Megginson <rmeggins@redhat.com> Fixes linux-system-roles#138
richm
added a commit
to richm/linux-system-roles-nbde_server
that referenced
this issue
Feb 14, 2024
…he role Cause: The role was assuming that the only file being managed in the tangd socket override directory was the override.conf file for the custom port. Consequence: The role would delete the directory if there was no custom port without checking if there were other files in that directory being used to override tangd settings. This would cause the directory to be recreated upon subsequent runs, and the role would report a change, and not appear to be idempotent. Fix: When adding the override directory for the port override file, do not change its attributes. Do not delete the directory if there are other files in it. Result: The role will co-exist with the tangd socket override files being managed outside of the role. Signed-off-by: Rich Megginson <rmeggins@redhat.com> Fixes linux-system-roles#138
|
@shaunjohnso are you able to try out #139? |
|
@richm tested and passed, confirmed fixed |
richm
added a commit
that referenced
this issue
Feb 14, 2024
…he role Cause: The role was assuming that the only file being managed in the tangd socket override directory was the override.conf file for the custom port. Consequence: The role would delete the directory if there was no custom port without checking if there were other files in that directory being used to override tangd settings. This would cause the directory to be recreated upon subsequent runs, and the role would report a change, and not appear to be idempotent. Fix: When adding the override directory for the port override file, do not change its attributes. Do not delete the directory if there are other files in it. Result: The role will co-exist with the tangd socket override files being managed outside of the role. Signed-off-by: Rich Megginson <rmeggins@redhat.com> Fixes #138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When configuring a custom port (port 80) for tangd using the playbook at https://github.com/linux-system-roles/nbde_server/blob/main/tasks/tangd-custom-port.yml, a critical error occurs during the idempotence test phase. The error indicates that specific tasks related to managing the tangd custom port and ensuring required services are enabled and at the correct state fail to execute idempotently. This issue was observed during the execution of an Ansible playbook that utilizes the fedora.linux_system_roles.nbde_server and my_tang_wrap roles.
Steps to Reproduce:
Clone the repository containing the nbde_server role.
Configure the playbook to set tangd to listen on port 80.
Create a custom directory /etc/systemd/system/tangd.socket.d.
Inside the /etc/systemd/system/tangd.socket.d directory, create a custom file named maxcon that includes an increase in connections to 1024.
Run the playbook once to apply the configuration.
Run the playbook again to test for idempotence.
Actual Behavior:
The second playbook execution fails the idempotence test with critical errors for the following tasks:
Manage tangd custom port systemd directory (repeatedly listed)
Ensure required services are enabled and at the right state (repeatedly listed)
Create Directory for Telnet Configuration (repeatedly listed)
Configure Maximum Telnet Connections (repeatedly listed)
These errors suggest that the playbook attempts to reapply configurations or settings that should already be in place, indicating a potential issue with how state is checked or managed for these tasks.
Logs:
CRITICAL Idempotence test failed because of the following tasks:
The text was updated successfully, but these errors were encountered: