Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library/NM: Always rollback checkpoint on failure #193

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

tyll
Copy link
Member

@tyll tyll commented Apr 16, 2020

If there is a NetworkManager checkpoint, roll it back on any failure.
Otherwise future invocations of the role fail until the checkpoint timed
out.

closes #154

@tyll
Copy link
Member Author

tyll commented Apr 16, 2020

I tested this manually with:
ansible-playbook -i rhel82-cloud, tests/tests_ethtool_features_initscripts.yml tests/tests_ethtool_features_nm.yml tests/tests_states.yml tests/tests_states.yml

@tyll
Copy link
Member Author

tyll commented Apr 17, 2020

@richm @pcahyna just for statistics, the CI is failing again for infrastructure problems, for example:

fatal: [/cache/Fedora-Cloud-Base-31-1.9.x86_64.qcow2]: FAILED! => {"changed": false, "msg": "Failed to download packages: Curl error (6): Couldn't resolve host name for https://mirrors.fedoraproject.org/metalink?repo=fedora-31&arch=x86_64 [Could not resolve host: mirrors.fedoraproject.org]", "results": []}

Copy link
Contributor

@thom311 thom311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tyll tyll force-pushed the checkpoint_cleanup branch 2 times, most recently from 67d2663 to 1334b35 Compare April 17, 2020 17:41
@tyll tyll changed the title Library/NM: Allways rollback checkpoint on failure Library/NM: Always rollback checkpoint on failure Apr 17, 2020
If there is a NetworkManager checkpoint, roll it back on any failure.
Otherwise future invocations of the role fail until the checkpoint timed
out.
@tyll tyll merged commit 1554c4a into linux-system-roles:master Apr 17, 2020
@tyll tyll deleted the checkpoint_cleanup branch April 17, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkpoint is not reverted when role aborts with log_error()
2 participants