New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pytest not reproducible in RHEL8 #402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1049263781
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1032223547
💛 - Coveralls |
richm
reviewed
Jul 15, 2021
cathay4t
approved these changes
Jul 15, 2021
lgtm - test passes on centos-8 and rhel-9 (when run manually) |
Previously when we run `tests_integration_pytest.yml` in RHEL 8, device becoming unmanaged and NM `ifup` command failed to bring up the connection when running pytest with initscripts, because network scripts are deprecated in RHEL8 and they are no longer provided by default. To fix that, install `network-scripts` package to utilize the legacy `ifup` command. Signed-off-by: Wen Liang <liangwen12year@gmail.com>
[citest bad] |
1 similar comment
[citest bad] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when we run
tests_integration_pytest.yml
in RHEL 8, devicebecoming unmanaged and NM
ifup
command failed to bring up theconnection when running pytest with initscripts, because network scripts
are deprecated in RHEL8 and they are no longer provided by default.
To fix that, install
network-scripts
package to utilize the legacyifup
command.Signed-off-by: Wen Liang liangwen12year@gmail.com