Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pytest not reproducible in RHEL8 #402

Merged
merged 1 commit into from Jul 22, 2021

Conversation

liangwen12year
Copy link
Collaborator

Previously when we run tests_integration_pytest.yml in RHEL 8, device
becoming unmanaged and NM ifup command failed to bring up the
connection when running pytest with initscripts, because network scripts
are deprecated in RHEL8 and they are no longer provided by default.

To fix that, install network-scripts package to utilize the legacy
ifup command.

Signed-off-by: Wen Liang liangwen12year@gmail.com

@coveralls
Copy link

coveralls commented Jul 15, 2021

Pull Request Test Coverage Report for Build 1049263781

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.085%

Totals Coverage Status
Change from base Build 1048064622: 0.0%
Covered Lines: 1039
Relevant Lines: 2592

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1032223547

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 40.054%

Files with Coverage Reduction New Missed Lines %
/home/runner/work/network/network/module_utils/network_lsr/ethtool.py 2 93.55%
/home/runner/work/network/network/library/network_connections.py 3 21.58%
Totals Coverage Status
Change from base Build 1001068449: -0.05%
Covered Lines: 1037
Relevant Lines: 2589

💛 - Coveralls

@cathay4t cathay4t enabled auto-merge (rebase) July 15, 2021 23:13
@richm
Copy link
Contributor

richm commented Jul 16, 2021

lgtm - test passes on centos-8 and rhel-9 (when run manually)

Previously when we run `tests_integration_pytest.yml` in RHEL 8, device
becoming unmanaged and NM `ifup` command failed to bring up the
connection when running pytest with initscripts, because network scripts
are deprecated in RHEL8 and they are no longer provided by default.

To fix that, install `network-scripts` package to utilize the legacy
`ifup` command.

Signed-off-by: Wen Liang <liangwen12year@gmail.com>
@richm
Copy link
Contributor

richm commented Jul 20, 2021

[citest bad]

1 similar comment
@richm
Copy link
Contributor

richm commented Jul 21, 2021

[citest bad]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants