Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to note that network teaming is deprecated in RHEL 9 #416

Closed
wants to merge 2 commits into from

Conversation

briansmith0
Copy link
Contributor

No description provided.

@richm
Copy link
Contributor

richm commented Sep 10, 2021

@briansmith0 you'll need to sign your commit - network role requires signed commits - probably the easiest way is to do git commit --amend -s then git push -f ....

@coveralls
Copy link

coveralls commented Sep 10, 2021

Pull Request Test Coverage Report for Build 1222658164

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 40.154%

Totals Coverage Status
Change from base Build 1169687266: -0.08%
Covered Lines: 1044
Relevant Lines: 2600

💛 - Coveralls

Signed-off-by: Brian Smith <briasmit@redhat.com>
@briansmith0
Copy link
Contributor Author

@richm Sounds good, I just completed those steps. Please let me know if this looks OK now or if there is anything else I need to do. Thanks!

@richm
Copy link
Contributor

richm commented Sep 11, 2021

@richm Sounds good, I just completed those steps. Please let me know if this looks OK now or if there is anything else I need to do. Thanks!

hmm - there are now 2 commits - the first one is signed, the 2nd not

@briansmith0
Copy link
Contributor Author

@richm I'm not sure how to fix this at this point. Could you reject/delete this PR and I can start over from scratch?

@richm richm closed this Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants