Support looking up named route table in routing rule #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[citest] |
1 similar comment
|
[citest] |
Merged
The user may need to define the named route table in the routing rule besides the table id, add support for that. The commit fixes linux-system-roles#506. Signed-off-by: Wen Liang <liangwen12year@gmail.com>
liangwen12year
force-pushed
the
named_table_support
branch
from
fee3ea6
to
03f88e2
Compare
ffmancera
approved these changes
Sep 30, 2022
|
I noticed the CI failures are related to the bond arp_all_targets issue, do you think we could mark them as xfail or skip until the new builds are in c8s and c9s? Thanks! |
I think that we may not test the corner cases anymore, instead, enable the arp_interval in the testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wen Liang liangwen12year@gmail.com