Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behavior for bridges on RHEL6 and RHEL7 #53

Closed
wants to merge 1 commit into from

Conversation

tyll
Copy link
Member

@tyll tyll commented May 18, 2018

This fails on RHEL6 and is related to #35 iirc.

@tyll tyll added the bug label May 18, 2018
@coveralls
Copy link

coveralls commented May 18, 2018

Pull Request Test Coverage Report for Build 189

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.698%

Totals Coverage Status
Change from base Build 186: 0.0%
Covered Lines: 779
Relevant Lines: 2013

💛 - Coveralls

@tyll tyll force-pushed the test_bridge branch 4 times, most recently from 3af0bd0 to e984e9b Compare May 25, 2018 18:38
@tyll
Copy link
Member Author

tyll commented Jul 10, 2018

[citest]

@tyll tyll force-pushed the test_bridge branch 4 times, most recently from 76bd9dd to 06538e5 Compare July 16, 2018 06:29
@tyll tyll mentioned this pull request Jul 16, 2018
@tyll
Copy link
Member Author

tyll commented Jul 16, 2018

The first two commits are parte of #72

tyll added a commit that referenced this pull request Jul 18, 2018
@pcahyna
Copy link
Member

pcahyna commented Jul 25, 2018

Should this PR be merged?

@tyll
Copy link
Member Author

tyll commented Jul 26, 2018

No, this was only to have a test case to be able to easily reproduce the inconsistent behavior. When the states are re-defined, then it can be adjusted and merged I guess.

@pcahyna
Copy link
Member

pcahyna commented Aug 21, 2018

When the states are re-defined, then it can be adjusted and merged I guess.

States were re-defined in #77. Can the test be adjusted now, please?

@tyll
Copy link
Member Author

tyll commented Aug 24, 2018

The new state definitions do not define the behavior for virtual interfaces. The test here checked whether the bridge device was removed after the profile was removed. This is now the persitence_state and it only defines whether the profile is on-disk but not whether the device exists. One could argue that state:down should remove the device but I am more convinced that it is not important to have a defined interface state. Therefore I close this PR now.

@tyll tyll closed this Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants