fix: add no_log: true for tasks that can log secret data #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cause: Some tasks handle secret data and log the contents. Consequence: The logs can show secret data if verbose logging is used. Fix: Add the `no_log: true` directive to tasks that can log secret data. Result: Secret data is not logged with verbose logging. Some of the tests use Ansible vault for passwords. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
requested review from
rhatdan,
baude,
vrothberg and
ikke-t
as code owners
|
[citest] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause: Some tasks handle secret data and log the contents.
Consequence: The logs can show secret data if verbose logging
is used.
Fix: Add the
no_log: truedirective to tasks that can logsecret data.
Result: Secret data is not logged with verbose logging.
Some of the tests use Ansible vault for passwords.
Signed-off-by: Rich Megginson rmeggins@redhat.com