fix: name of volume quadlet service should be basename-volume.service #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cause: The code was using a volume quadlet service name of basename.volume. Consequence: Attempting to start this service name would give an error such as "Could not find the requested service NAME.volume: host" Fix: The volume quadlet service name is changed to basename-volume.service Result: The volume service can be started with no errors. See https://docs.podman.io/en/latest/markdown/podman-systemd.unit.5.html#volume-units-volume for more info. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
requested review from
rhatdan,
baude,
vrothberg and
ikke-t
as code owners
|
[citest] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause: The code was using a volume quadlet service name of basename.volume.
Consequence: Attempting to start this service name would give an error such
as "Could not find the requested service NAME.volume: host"
Fix: The volume quadlet service name is changed to basename-volume.service
Result: The volume service can be started with no errors.
See https://docs.podman.io/en/latest/markdown/podman-systemd.unit.5.html#volume-units-volume
for more info.
Signed-off-by: Rich Megginson rmeggins@redhat.com