fix: cast secret data to string in order to allow JSON valued strings #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cause: Ansible is somehow converting JSON strings to the corresponding
JSON object if the value is used in a loop and the value is used
like `data: "{{ value }}"`
Consequence: You cannot pass JSON strings as secrets and have the
value preserved.
Fix: Cast the data value to a string when passing to the podman_secret
module.
Result: JSON strings are preserved as-is for use in secrets.
Github issue: linux-system-roles#121
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
requested review from
rhatdan,
baude,
vrothberg and
ikke-t
as code owners
Closed
|
[citest] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause: Ansible is somehow converting JSON strings to the corresponding
JSON object if the value is used in a loop and the value is used
like
data: "{{ value }}"Consequence: You cannot pass JSON strings as secrets and have the
value preserved.
Fix: Cast the data value to a string when passing to the podman_secret
module.
Result: JSON strings are preserved as-is for use in secrets.
Github issue: #121
Signed-off-by: Rich Megginson rmeggins@redhat.com