solve issues 55;56;59;60;67...81;83 #82
Conversation
sync to fork
…AP note 2777782 v10 or later
Work against Bernds branch
This update targets the Issue (linux-system-roles#68) in linux-system-roles linux-system-roles#68 IBM has only transfered this information internally, the official page is still under construction The packages are the same as for RHEL7 but powerpc-utils-python. This is no longer available for RHEL8.
fixes linux-system-roles#67 The command needs-restarting is part of the package yum-utils, which is not in the list of required packages (i.e.@base or @server) This command is used to check if a reboot of the server is required. Hence yum-utils is added to the list of required packages. This command is used in the module "check if reboot is required (7.3+)" Currently this module is only executed on RHEL7, so the when statement is changed accordingly. If the command is not installed this module fails. If the module named "check if reboot is required (7.3+)" is skipped the according variable "sap_hana_preconfigure_register_reboot_required" is not set. If the default value of "sap_hana_preconfigure_reboot_after_update" is changed to true and sap_hana_preconfigure_register_reboot_required is not set the playbook will fail with unset variable.
Updated Required Package List for RHEL8 ppcle
- required for update and reboot - role internal variables should start with two underscores - fix indentation - Support for single step execution or checking of SAP notes - no need to handle selinux in this role - 2455582.yml can be removed. - Support RHEL 7 and RHEL 8 and both architectures when checking enabled repos - No longer support strict version checking for SAP HANA - Add a warning to README.md - Support check mode for reboot handler - Enable setting the RHEL release to a certain fixed minor release
README.md
Outdated
| ---- | ||
| For finding out which SAP notes will be used by this role, please check the contents of variable __sap_hana_preconfigure_sapnotes in files vars/*.yml (choose the file which matches your OS distribution and version) | ||
|
|
||
| Please do not run this role against a productive SAP HANA system. The role will unconditionally make changes to the managed node, which might not be intended on productive SAP HANA systems. |
There was a problem hiding this comment.
I rephrased the warning in berndfinger@ce162cb .
| - name: On RHEL 8.0 on ppc64le, switch to tuned profiles sap-hana sap-hana-ppc64le if not currently active | ||
| block: | ||
| - name: Switch to tuned profiles sap-hana sap-hana-ppc64le if not currently active | ||
| shell: /usr/sbin/tuned-adm profile sap-hana sap-hana-ppc64le |
There was a problem hiding this comment.
you can use command here instead of shell
There was a problem hiding this comment.
done - berndfinger@318a2c6
| - debug: | ||
| var: command_result.stdout_lines, command_result.stderr_lines | ||
| - name: "Run grub-mkconfig (BIOS mode)" | ||
| command: bash -lc "grub2-mkconfig -o /boot/grub2/grub.cfg" |
There was a problem hiding this comment.
why not use command: grub2-mkconfig -o /boot/grub2/grub.cfg? You have to run bash as a login shell here?
There was a problem hiding this comment.
command without bash should actually work fine. Will test and change if passed.
There was a problem hiding this comment.
done - berndfinger@318a2c6
berndfinger
changed the title
| ```yaml | ||
| sap_hana_preconfigure_switch_to_tuned_profile_sap_hana | ||
| ``` | ||
|
|
||
| ### Use tuned profile sap-hana where possible | ||
| If you do not want to use the tuned profile sap-hana for configuring kernel parameters (where possible), and have the role configure them instead, set the following variable to `no`. Default is `yes`. | ||
| If you do not want to use the tuned profile sap-hana for configuring kernel parameters (where possible), and have the role configure them by changing the kernel command line instead, set the following variable to `no`. Default is `yes`. In case of `yes`, variable `sap_hana_preconfigure_switch_to_tuned_profile_sap_hana` (see above) should be set to `yes` as well. | ||
| Note: If this variable is set to `yes`, the role will not modify GRUB_CMDLINE_LINUX in /etc/default/grub, no matter how `sap_hana_preconfigure_modify_grub_cmdline_linux` (see below) is set. |
There was a problem hiding this comment.
@berndfinger not suggesting you do this now, but possibly for a future release - did you investigate using the tuned profile to configure the bootloader cmdline?
There was a problem hiding this comment.
Yes, I found that the three kernel boot cmdline parameters which are configured by this role are all covered by tuned-profiles-sap-hana. Here's the list:
CMDLINE: transparent_hugepage=never
tuned-profiles-sap-hana: transparent_hugepages=never
See https://github.com/berndfinger/sap-hana-preconfigure/blob/006a1c907953382860486528cdff13c344632309/tasks/RedHat/generic/disable-thp.yml#L6
CMDLINE: processor.max_cstate=1 intel_idle.max_cstate=1
tuned-profiles-sap-hana: force_latency=70 or force_latency=cstate.id:3|70
See https://github.com/berndfinger/sap-hana-preconfigure/blob/006a1c907953382860486528cdff13c344632309/tasks/RedHat/generic/configure-c-states-for-lower-latency.yml#L6
#55: Use ansible reboot module
#56: Role is not recognizing cloud eus/e4s repositories
#59: feature idea: moving reboot to after all configuration changes
#60: handler: regenerate grub2 conf not working on ansible 2.8
#67: reboot fails on RHEL 8
#68: RHEL 8 PPCLE Packages
#69: Add support for --check (-c) option
#70: role fails, if firewalld is not installed
#71: update_only is not a valid parameter for package module
#72: required for update and reboot
#73: role internal variables should start with two underscores
#74: fix indentation
#75: Support for single step execution or checking of SAP notes
#76: no need to handle selinux in this role
#77: 2455582.yml can be removed.
#78: Support RHEL 7 and RHEL 8 and both architectures when checking enabled repos
#79: No longer support strict version checking for SAP HANA
#80: Add a warning to README.md
#81: Enable setting the RHEL release to a certain fixed minor release
#83: Warning needs to be rephrased.