-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ssh_backup option with default true #91
Conversation
Code-wise looks good. Would be great if we could have some test coverage for this option. You can get some inspiration from the sshd role, which has https://github.com/willshersystems/ansible-sshd/blob/master/tests/tests_backup.yml |
ping - also requires rebase |
18d6846
to
77b17ce
Compare
I did the rebase + added the adjusted backup tests (as in ansible-sshd). I however cannot properly test because I don't get tox-lsr running on my machine. I would thus appreciate if somebody else could fix the remaining issues. |
a847cd2
to
7106518
Compare
[citest] |
lgtm, except for the minor ansible-lint issues, and the Ubuntu tests |
analog to sshd_backup tests (willshersystems/ansible-sshd)
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
I squashed the commits and added fixes/tests improvements to make the Ubuntu checks working in my branch where the CI now passes: |
Please, rebase instead of merging to have nicer git history. Now the CI is green we should be good to go. |
f014647
to
dc6edac
Compare
@Jakuje it should be fine now. |
Thank you! Asking also @richm for review/merge as some of the test cleanup commits was from me. |
No description provided.