Updated version of #50 #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that disk volumes mean filesystems directly on disks. Currently the test fails: on first invocation the filesystem gets mounted by device name and only on the second by UUID. This should be also aught by a real idempotence test. XXX this should be part of the existing verification task lists: there is already a task called "Verify that the device identifier appears in /etc/fstab", but it does not check for this condition.
pcahyna
force-pushed
the
uuid-fstab-broken
branch
from
d92ad0d
to
4ea9545
Compare
richm
reviewed
Aug 31, 2020
tests/tests_change_disk_fs.yml
Outdated
| @@ -6,7 +6,7 @@ | |||
| mount_location: '/opt/test' | |||
| volume_size: '5g' | |||
| fs_type_after: "{{ 'ext3' if (ansible_distribution == 'RedHat' and ansible_distribution_major_version == '6') else 'ext4' }}" | |||
|
|
|||
| pat: "{{ '^([^#\\s]+)\\s+' + mount_location + '\\s.*' }}" | |||
| tasks: | |||
| - include_role: | |||
| name: storage | |||
There was a problem hiding this comment.
please use name: linux-system-roles.storage
This was referenced Mar 13, 2021
|
[citest pending] |
|
[citest bad] |
|
[citest pending] |
use `linux-system-roles.storage` - fix indentation
|
[citest pending] |
3 similar comments
|
[citest pending] |
|
[citest pending] |
|
[citest pending] |
richm
reviewed
Nov 20, 2021
|
|
||
| - name: print fstab device | ||
| debug: | ||
| msg: device is: {{ ( _test_change_disk_fs_fstab1.stdout_lines|select('search', pat) |
There was a problem hiding this comment.
This string must be quoted because jinja2/yaml doesn't like the colon : character in is::
Exception when running tests: mapping values are not allowed here
in "<unicode string>", line 37, column 23:
msg: device is: {{ ( _test_change_disk_fs_fsta ...
^ (line: 37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
up to but not including the commit that probably fixed the problem.