feat: User-specified mount point owner and permissions #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japokorn
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
==========================================
- Coverage 13.90% 12.19% -1.71%
==========================================
Files 8 8
Lines 1705 1705
Branches 71 0 -71
==========================================
- Hits 237 208 -29
- Misses 1468 1497 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
japokorn
force-pushed
the
main-mnt_owner_permissions
branch
4 times, most recently
from
a638c00
to
850f93e
Compare
japokorn
changed the title
japokorn
changed the title
richm
reviewed
May 16, 2023
richm
reviewed
May 16, 2023
richm
reviewed
May 16, 2023
richm
reviewed
May 16, 2023
richm
reviewed
May 16, 2023
richm
reviewed
May 16, 2023
richm
reviewed
May 16, 2023
richm
reviewed
May 16, 2023
richm
reviewed
May 16, 2023
|
Also need an update to the README.md |
|
Did you push your new commit(s)? |
japokorn
force-pushed
the
main-mnt_owner_permissions
branch
from
850f93e
to
cfd7781
Compare
Added new volume options related to mount point directory: mount_user - directory owner (string) mount_group - directory group (string) mount_permissions - directory permissions (string; same format as chmod) Resolves: rhbz#2181661
richm
reviewed
May 17, 2023
tasks/main-blivet.yml
Outdated
| group: "{{ mount_info['group'] if 'group' in mount_info else omit }}" | ||
| mode: "{{ mount_info['mode'] if 'mode' in mount_info else omit }}" | ||
| state: directory | ||
| when: "{{ mount_info['owner'] != none or mount_info['group'] != none or mount_info['mode'] != none }}" |
There was a problem hiding this comment.
Suggested change
| when: "{{ mount_info['owner'] != none or mount_info['group'] != none or mount_info['mode'] != none }}" | |
| when: mount_info['owner'] != none or mount_info['group'] != none or | |
| mount_info['mode'] != none |
japokorn
force-pushed
the
main-mnt_owner_permissions
branch
from
cfd7781
to
14328ba
Compare
My apologies, I am replying to comments that I have fixed locally, so I know I have handled them. |
|
[citest] |
Looks good now. |
richm
added a commit
to richm/linux-system-roles-storage
that referenced
this pull request
May 23, 2023
Turns out that the systemd refresh removed as part of linux-system-roles#352 was needed. This fix adds it back. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
that referenced
this pull request
May 23, 2023
Turns out that the systemd refresh removed as part of #352 was needed. This fix adds it back. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new volume options related to mount point directory: mount_user - directory owner (string)
mount_group - directory group (string)
mount_permissions - directory permissions (string; same format as chmod)
Resolves: rhbz#2181661