feat: Stratis support

[vojtechtrefny]

Support for creating and managing Stratis pools and volumes. For now this is just a draft because we need a new version of Blivet to be available for the full support. This includes support for creating Stratis pools and filesystems and adding new block devices to an existing Stratis pool (removing block devices is not supported by Stratis). Encrypted Stratis pools can be created with Clevis/Tang or TPM support.

Resolves: RHEL-31854

[spetrosi]

Does it make sense to separate packages, and only install once that are needed. E.g. for this use case, add a blivet_stratis_packages and install these packages only when user sets stratis variables?

[vojtechtrefny]

It's probably worth installing the dependencies a bit "smarter" -- we already have VDO here which also isn't that widely used.

[richm]

Note that blivet already has a way to return a list of package names that are required to perform the given actions - https://github.com/linux-system-roles/storage/blob/main/tasks/main-blivet.yml#L21 - can that be extended to include all of the packages we currently put in the various vars files, such as vdo, xfsprogs, etc.?

[vojtechtrefny]

Blivet with full support for all Stratis features in this PR is now available on both RHEL (9 and 10) and Fedora so I am marking this as ready for review. The pylint failures are fixed in #440

[richm]

[citest]

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 127 lines in your changes missing coverage. Please review.

Project coverage is 10.90%. Comparing base (acd20be) to head (9be4bd6).
Report is 12 commits behind head on main.

Files	Patch %	Lines
library/blivet.py	0.00%	106 Missing ⚠️
library/blockdev_info.py	0.00%	21 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
- Coverage   16.54%   10.90%   -5.65%     
==========================================
  Files           2        8       +6     
  Lines         284     1917    +1633     
  Branches       79        0      -79     
==========================================
+ Hits           47      209     +162     
- Misses        237     1708    +1471     

Flag	Coverage Δ
sanity	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vojtechtrefny]

[citest]

[richm]

the centos9 statis test fails:

TASK [fedora.linux_system_roles.storage : Manage the pools and volumes to match the specified state] ***
task path: /WORKDIR/git-main_stratis-support-25ax7xqcj/.collection/ansible_collections/fedora/linux_system_roles/roles/storage/tasks/main-blivet.yml:69
Friday 31 May 2024  17:45:03 +0000 (0:00:00.010)       0:01:05.969 ************ 
fatal: [sut]: FAILED! => {
    "actions": [],
    "changed": false,
    "crypts": [],
    "leaves": [],
    "mounts": [],
    "packages": [],
    "pools": [],
    "volumes": []
}

MSG:

failed to set up pool 'foo': __init__() got an unexpected keyword argument 'clevis'

[vojtechtrefny]

[citest]

[vojtechtrefny]

[citest]

[vojtechtrefny]

[citest]

[vojtechtrefny]

[citest]

[richm]

please rebase on top of the latest main branch to pick up test fixes

[vojtechtrefny]

[citest]