Use GITHUB_REF_NAME as name of push branch; fix error in branch detection [citest skip] #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion [citest skip] We need to get the name of the branch to which CHANGELOG.md was pushed. For now, it looks as though `GITHUB_REF_NAME` is that name. But don't trust it - first, check that it is `main` or `master`. If not, then use a couple of other methods to determine what is the push branch. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to richm/linux-system-roles-vpn
that referenced
this pull request
Sep 19, 2022
[1.3.6] - 2022-09-19 -------------------- ### New Features - Various improvements required to connect to a managed remote host (linux-system-roles#65) Add support for the parameters shared_key_content, leftid, rightid, ike, esp, type, ikelifetime, salifetime, retransmit_timeout, dpddelay, dpdtimeout, dpdaction, leftupdown ### Bug Fixes - Check for /usr/bin/openssl on controller - do not use package_facts (linux-system-roles#66) Check for existence of openssl without using sudo on the controller Basically, any task, even package_facts:, will use sudo if using become=true - so just use "exists" test to check for /usr/bin/openssl ### Other Changes - Fix a bash bug in changelog_to_tag.yml, which unexpectedly expanded "*" (linux-system-roles#62) - changelog_to_tag action - support other than "master" for the main branch name, as well (linux-system-roles#63) - Use GITHUB_REF_NAME as name of push branch; fix error in branch detection [citest skip] (linux-system-roles#64) We need to get the name of the branch to which CHANGELOG.md was pushed. For now, it looks as though `GITHUB_REF_NAME` is that name. But don't trust it - first, check that it is `main` or `master`. If not, then use a couple of other methods to determine what is the push branch. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to richm/linux-system-roles-vpn
that referenced
this pull request
Sep 19, 2022
[1.4.0] - 2022-09-19 -------------------- - Various improvements required to connect to a managed remote host (linux-system-roles#65) Add support for the parameters shared_key_content, leftid, rightid, ike, esp, type, ikelifetime, salifetime, retransmit_timeout, dpddelay, dpdtimeout, dpdaction, leftupdown - Check for /usr/bin/openssl on controller - do not use package_facts (linux-system-roles#66) Check for existence of openssl without using sudo on the controller Basically, any task, even package_facts:, will use sudo if using become=true - so just use "exists" test to check for /usr/bin/openssl - Fix a bash bug in changelog_to_tag.yml, which unexpectedly expanded "*" (linux-system-roles#62) - changelog_to_tag action - support other than "master" for the main branch name, as well (linux-system-roles#63) - Use GITHUB_REF_NAME as name of push branch; fix error in branch detection [citest skip] (linux-system-roles#64) We need to get the name of the branch to which CHANGELOG.md was pushed. For now, it looks as though `GITHUB_REF_NAME` is that name. But don't trust it - first, check that it is `main` or `master`. If not, then use a couple of other methods to determine what is the push branch. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
that referenced
this pull request
Sep 19, 2022
[1.4.0] - 2022-09-19 -------------------- - Various improvements required to connect to a managed remote host (#65) Add support for the parameters shared_key_content, leftid, rightid, ike, esp, type, ikelifetime, salifetime, retransmit_timeout, dpddelay, dpdtimeout, dpdaction, leftupdown - Check for /usr/bin/openssl on controller - do not use package_facts (#66) Check for existence of openssl without using sudo on the controller Basically, any task, even package_facts:, will use sudo if using become=true - so just use "exists" test to check for /usr/bin/openssl - Fix a bash bug in changelog_to_tag.yml, which unexpectedly expanded "*" (#62) - changelog_to_tag action - support other than "master" for the main branch name, as well (#63) - Use GITHUB_REF_NAME as name of push branch; fix error in branch detection [citest skip] (#64) We need to get the name of the branch to which CHANGELOG.md was pushed. For now, it looks as though `GITHUB_REF_NAME` is that name. But don't trust it - first, check that it is `main` or `master`. If not, then use a couple of other methods to determine what is the push branch. Signed-off-by: Rich Megginson <rmeggins@redhat.com> Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to get the name of the branch to which CHANGELOG.md was pushed.
For now, it looks as though
GITHUB_REF_NAMEis that name. But don'ttrust it - first, check that it is
mainormaster. If not, then usea couple of other methods to determine what is the push branch.
Signed-off-by: Rich Megginson rmeggins@redhat.com