Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtest06: mmap1 test execution time and LTP_TIMEOUT_MUL #824

Closed
multiple1 opened this issue Jun 2, 2021 · 4 comments
Closed

mtest06: mmap1 test execution time and LTP_TIMEOUT_MUL #824

multiple1 opened this issue Jun 2, 2021 · 4 comments

Comments

@multiple1
Copy link

Hello!

For me it looks like mmap1 executes its test until the test reaches the set timeout.
mmap1 will stop its execution if only n seconds are remaining until timeout.
https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/mem/mtest06/mmap1.c#L228

The test argument -x 0.02 changes the test timeout.
https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/mem/mtest06/mmap1.c#L219

But if I set LTP_TIMEOUT_MUL=2 the ltp lib will multiply the set timeout e.g. -x 0.02*2.
So the test would run twice as long, or am I wrong?
I think mmap1 and maybe other tests misuse the timeout mechanism of ltp?

@metan-ucw
Copy link
Member

metan-ucw commented Jun 2, 2021

This is known problem, timeout multiplication only increases tests runtime in this case and yes I do plan to introduce a new variable something as LTP_MAX_RUNTIME as currently there is no way how to set a test runtime for these testcases.

@multiple1
Copy link
Author

Ok, good to know. So for now LTP_TIMEOUT_MUL can/should not be used.

@metan-ucw
Copy link
Member

I've send a patchset that attempts to fix this issue http://patchwork.ozlabs.org/project/ltp/list/?series=247935 I guess that there will be some changes needed before it could be applied but it should show the direction where this is heading to.

@metan-ucw
Copy link
Member

Should be fixed by the runtime patchset starting with 0f72d51 patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants