Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readahead02.c fixes #972

Open
metan-ucw opened this issue Sep 16, 2022 · 8 comments
Open

readahead02.c fixes #972

metan-ucw opened this issue Sep 16, 2022 · 8 comments
Labels

Comments

@metan-ucw
Copy link
Member

metan-ucw commented Sep 16, 2022

There are a couple things that should be fixed in the test:

We run the test with a loop device it will fail with ENOSPC if we pass -s bigger than the loop device, we should at least check if the device is large enough in the test setup.

The test should make use of use tst_parse_filesize() so that we can pass sizes with units e.g. -s 128M.

As we run the test inside a loop device I guess that we can also sync and drop caches just for the device, which should be faster than syncing and dropping the whole system. Possibly we just need to umount it and mount it again.

@metan-ucw metan-ucw added the bug label Sep 16, 2022
@indumathiraju
Copy link

Hi,
Could you please tell what are the required configurations and packages for LTP to make all tests get Pass ?

Thank you

@metan-ucw
Copy link
Member Author

@indumathiraju this is not really the right place to ask this question, this issue is about bugs in readahead02 test. Question like this are best to be raised on the project mailing list.

@Avinesh
Copy link
Contributor

Avinesh commented Sep 20, 2022

@coolgw
Copy link
Contributor

coolgw commented Jan 29, 2023

@Martchus
Copy link
Contributor

Looks like the patch linked by @coolgw hasn't been merged yet. I'm wondering what was missing. Is there a way to display reviews in patchwork?

@coolgw
Copy link
Contributor

coolgw commented Sep 28, 2023

@Martchus you can check v4, v3 etc in patchwork. There has some review comments.
such as https://patchwork.ozlabs.org/project/ltp/patch/20230116111749.18865-1-wegao@suse.com/

@Martchus
Copy link
Contributor

you can check v4, v3 etc in patchwork

I've been following your link. However, I'm wondering how one can navigate from one version to another in patchwork? (Or how can one search for patches? I haven't found a search form anywhere.)

There has some review comments.

Ah, so I understand that you're waiting for further feedback here.

@pevik
Copy link
Member

pevik commented Sep 29, 2023

you can check v4, v3 etc in patchwork

I've been following your link. However, I'm wondering how one can navigate from one version to another in patchwork? (Or how can one search for patches? I haven't found a search form anywhere.)

@Martchus Unfortunately patchwork does not connect series together, this functionality would have to be added. There is already ticket for it: getpatchwork/patchwork#506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants