Secure boot keys endianness improvements #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secure boot tests on SAMA5D2 indicate that the KEYWRx and IVRx registers are big-endian. This is documented in paragraph 57.4.1 (AES Register Endianness) of the SAMA5D2 datasheet (rev. 11267E, 25-Jul-16). Switch endianness of the values written to these registers. This allows expressing the .config key values in natural hexadecimal writing, where the left most digit is the most significant, and the right most is the least significant. Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
|
Thanks. |
There was a problem hiding this comment.
It looks good to me.
Just be carefull about the swab32() macro: it will work as expected as long as x is an unsigned int but may l faill with a signed int. Here, it works because both key[i] and iv[i] are unsigned int.
((x) & 0xff000000UL) >> 24 fails with a negative x.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two commits improve the usability of secure boot with regards to endianness of keys and IV.
Patches were tested on a SAMA5D2 Xplained board.