Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license checks for non-go files #28

Open
mimir-d opened this issue Oct 28, 2021 · 0 comments
Open

Fix license checks for non-go files #28

mimir-d opened this issue Oct 28, 2021 · 0 comments

Comments

@mimir-d
Copy link
Member

mimir-d commented Oct 28, 2021

Issue by insomniacslk
Thursday Dec 03, 2020 at 21:20 GMT
Originally opened as https://github.com/facebookincubator/contest/issues/192


As noted in https://github.com/facebookincubator/contest/pull/188 our CI doesn't detect correctly when non-go files are missing the copyright header. Specifically, despite adding *.sql to the configuration of checklicenses, it always reports success, even when the license header is missing or wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant