Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Added missing copyright header #188

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Conversation

insomniacslk
Copy link
Contributor

Signed-off-by: Andrea Barberio insomniac@slackware.it

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 1, 2020
@insomniacslk
Copy link
Contributor Author

Hopefully this won't create any problem with goose's parsing of that file

@marcoguerri
Copy link
Contributor

Bah, this again, sorry. Doesn't the linter run as part of the integ test run in the container? Probably we already discussed this, I forgot what the outcome of this discussion was.

Hopefully this won't create any problem with goose's parsing of that file

Tested locally and it doesn't interfere with the parsing, anyway the integ test run will exercise the migration so it should confirm.

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #188 (0141ee0) into master (efb4e54) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   62.06%   62.14%   +0.07%     
==========================================
  Files          82       82              
  Lines        3883     3883              
==========================================
+ Hits         2410     2413       +3     
+ Misses       1186     1183       -3     
  Partials      287      287              
Flag Coverage Δ
integration 59.29% <ø> (+0.18%) ⬆️
integration_storage 100.00% <ø> (?)
unittests 27.61% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/teststeps/teststeps.go 78.87% <0.00%> (+4.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efb4e54...0141ee0. Read the comment docs.

@insomniacslk
Copy link
Contributor Author

Bah, this again, sorry. Doesn't the linter run as part of the integ test run in the container? Probably we already discussed this, I forgot what the outcome of this discussion was.

The public linter ignores non-go files while the internal one doesn't. I can adjust the public linter to include sql, one sec

Signed-off-by: Andrea Barberio <insomniac@slackware.it>
@insomniacslk
Copy link
Contributor Author

Updated, but I have to change the regexp too, to match the sql-style comments, one sec

@insomniacslk
Copy link
Contributor Author

Updated, but I have to change the regexp too, to match the sql-style comments, one sec

Interestingly, it returns success, but it should fail because of the different comment style

@insomniacslk
Copy link
Contributor Author

insomniacslk commented Dec 1, 2020

not sure why this is happening, but sounds like a bug in checklicenses

@insomniacslk
Copy link
Contributor Author

will look at that tomorrow

@insomniacslk
Copy link
Contributor Author

@marcoguerri if that's OK I will merge this to fix the copyright header, and file an issue for checklicenses

@marcoguerri
Copy link
Contributor

Sorry for the latency, yes, that's perfectly fine.

@insomniacslk insomniacslk merged commit bf421f7 into master Dec 3, 2020
@insomniacslk insomniacslk deleted the fix_missing_copyright_header branch December 3, 2020 21:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants