Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Propagate context values #166

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

xaionaro
Copy link
Member

See the unit-test.

@xaionaro xaionaro requested a review from mimir-d June 16, 2023 13:30
Copy link
Member

@mimir-d mimir-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some broken code and questions

pkg/api/reset_context_keep_values.go Outdated Show resolved Hide resolved
pkg/api/reset_context_keep_values.go Outdated Show resolved Hide resolved
pkg/api/api.go Show resolved Hide resolved
@xaionaro xaionaro force-pushed the bugfix/propagate_context_values branch 3 times, most recently from b160a03 to 3de0251 Compare June 16, 2023 15:31
mimir-d
mimir-d previously approved these changes Jun 20, 2023
pkg/api/api.go Outdated Show resolved Hide resolved
Signed-off-by: Dmitrii Okunev <xaionaro@meta.com>
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 86.66% and project coverage change: +0.03 🎉

Comparison is base (eca9e1e) 61.81% compared to head (e78f3d4) 61.85%.

❗ Current head e78f3d4 differs from pull request most recent head fb97c4d. Consider uploading reports for the commit fb97c4d to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #166      +/-   ##
===========================================
+ Coverage    61.81%   61.85%   +0.03%     
===========================================
  Files          130      131       +1     
  Lines         9214     9228      +14     
===========================================
+ Hits          5696     5708      +12     
- Misses        2847     2849       +2     
  Partials       671      671              
Flag Coverage Δ
e2e 49.66% <86.66%> (+0.07%) ⬆️
integration 56.95% <86.66%> (+0.09%) ⬆️
unittests 46.13% <73.33%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/values_proxy_context.go 83.33% <83.33%> (ø)
pkg/api/api.go 71.62% <100.00%> (+0.38%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xaionaro xaionaro merged commit fa98f00 into develop Jun 21, 2023
5 checks passed
@xaionaro xaionaro deleted the bugfix/propagate_context_values branch June 21, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants