Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 4.2.1, hashes, external coreboot crossgcc, circleci and other fixes #457

Merged
merged 19 commits into from
Apr 23, 2019

Conversation

osresearch
Copy link
Collaborator

This enables make 4.2.1 on ubuntu 18.04 (#352), adds hashes of built images (#455), speeds up circleci builds by using an external coreboot crossgcc (#162). There is now a dockerhub image for ubuntu 16.04: https://hub.docker.com/r/osresearch/heads-ubuntu/ with musl-gcc and coreboot gcc. Builds like https://circleci.com/gh/osresearch/heads/28 seem to work.

@hugelgupf
Copy link
Member

Nice. Can you commit the dockerfile that built the image, too?

@tlaurion
Copy link
Collaborator

tlaurion commented Feb 8, 2019

@osresearch : Any reason why this wasn't merged yet?

Latest builds fails on your CI:

'standard output': Resource temporarily unavailable
tail /root/project/build/log/musl-cross.log
-----
+ btool=x86_64-musl-linux-readelf
+ [ x86_64-linux-musl-readelf != x86_64-musl-linux-readelf -a ! -e x86_64-musl-linux-readelf ]
+ ln -s x86_64-linux-musl-readelf x86_64-musl-linux-readelf
+ echo x86_64-linux-musl-size
+ sed s/-linux-musl/-musl-linux/
+ btool=x86_64-musl-linux-size
+ [ x86_64-linux-musl-size != x86_64-musl-linux-size -a ! -e x86_64-musl-linux-size ]
+ ln -s x86_64-linux-musl-size x86_64-musl-linux-size
+ echo x86_64-linux-musl-strings
+ sed s/-linux-musl/-musl-linux/
+ btool=x86_64-musl-linux-strings
+ [ x86_64-linux-musl-strings != x86_64-musl-linux-strings -a ! -e x86_64-musl-linux-strings ]
+ ln -s x86_64-linux-musl-strings x86_64-musl-linux-strings
+ echo x86_64-linux-musl-strip
+ sed s/-linux-musl/-musl-linux/
+ btool=x86_64-musl-linux-strip
+ [ x86_64-linux-musl-strip != x86_64-musl-linux-strip -a ! -e x86_64-musl-linux-strip ]
+ ln -s x86_64-linux-musl-strip x86_64-musl-linux-strip
+ exit 0
make[1]: Leaving directory '/root/project/build/musl-cross-git'
make: *** [Makefile:356: /root/project/build/musl-cross-git/.build] Error 1
Exited with code 2

@cawilliamson
Copy link
Contributor

I've just built heads using this patch and it worked flawlessly for me on Ubuntu 18.04 as promised.

With that in mind - I think it's probably time to get this one merged! +1

@tlaurion
Copy link
Collaborator

tlaurion commented Feb 20, 2019

@flammit @kylerankin : should we merge?
I tried to contact @nemanjan00 and @osresearch so that their docker images (1) (2) are updated without any feedback.

I'm building with fedora-29 without any issues.

@tlaurion
Copy link
Collaborator

tlaurion commented Apr 13, 2019

@osresearch @flammit @hugelgupf @kylerankin @cawilliamson @strugee :
If there is no opposition, i'll merge that PR next week.

Collaboration is key, guys :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants