patches: Add patch to fix hotp-verification #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 7ea13ee made some significant changes to Librem/Nitrokey verification which broke both compilation and calls to hotp_initialize. Fix them via a patch until it's fixed upstream. Signed-off-by: Matt DeVillier <matt.devillier@puri.sm>
|
@alex-nitrokey Please fix upstream. Merging. |
|
@tlaurion looks like Nitrokey/nitrokey-hotp-verification#11 |
|
Sorry for the confusion. For the #761 I used the commit of Nitrokey/nitrokey-hotp-verification#11 that wasn't merged yet, thus by merging #774 the needed PR wasn't included in heads anymore. |
|
@MrChromebox @alex-nitrokey : tested https://app.circleci.com/pipelines/github/tlaurion/heads/266/workflows/d2135353-dc67-4972-afc2-473ca4a969e0/jobs/289/artifacts which included #784 #779 #778 #658 without build problems with problems reported in proper PR, others merged. |
|
looks like nitrokey merged the PR on their end, so I'll submit a PR to drop this patch and update to hotp-verification master |
|
pushed #786 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 7ea13ee made some significant changes to Librem/Nitrokey
verification which broke both compilation and calls to hotp_initialize.
Fix them via a patch until it's fixed upstream.
Signed-off-by: Matt DeVillier matt.devillier@puri.sm