contributing formulae

[benswift]

Hey folks

I've contributed a few formulae to homebrew on OSX. I've also just set it up on Linux (Ubuntu 13.10) and fixed a few bugs in various formulae.

If I want to contribute these changes back upstream, how do I do that considering I've already forked homebrew to make my osx changes. So when I try and fork homebrew/linuxbrew (as I would for mxcl/homebrew to contribute on OSX) it just takes me to my existing fork.

Is there a way to force a second fork on GH with a new name? Is there a better way to do it?

[sjackman]

Hi, Ben. I believe you only need a single fork. Configure your working copy of Homebrew to have three remotes: mxcl/homebrew, homebrew/linuxbrew and benswift/homebrew. You will be tracking two branches: master and linuxbrew.

[remote "origin"]
    url = https://github.com/mxcl/homebrew
    fetch = +refs/heads/*:refs/remotes/origin/*
[remote "sjackman"]
    url = https://github.com/sjackman/homebrew
    fetch = +refs/heads/*:refs/remotes/sjackman/*
[remote "linuxbrew"]
    url = https://github.com/Homebrew/linuxbrew
    fetch = +refs/heads/*:refs/remotes/linuxbrew/*
[branch "master"]
    remote = origin
    merge = refs/heads/master
[branch "linuxbrew"]
    remote = linuxbrew
    merge = refs/heads/linuxbrew

[benswift]

Cool, thanks mate.

I've fixed up a couple of formula which weren't building for me (Ubuntu 13.10), do you want me to push the patches upstream? Do I just create new branches for each formula as they like for OSX?

[sjackman]

Yes, that'd be great. The patches should be guarded in if OS.linux? and if OS.mac? so that the formula still build correctly on OS X.

[benswift]

Ah, cool, that's how we're doing it. I was wondering about that. So do they have to be reviewed by both maintainers now?

On 13/11/2013, at 1:07 PM, Shaun Jackman notifications@github.com wrote:

Yes, that'd be great. The patches should be guarded in if OS.linux? and if OS.mac? so that the formula still build correctly on OS X.

—
Reply to this email directly or view it on GitHub.

[sjackman]

Portability patches sadly aren't generally being accepted into mxcl/homebrew. Feel free to petition them to hopefully change this policy.

[benswift]

Ah, ok. So we'll just keep on adding the if OS.blah checks just in case, but for the moment we'll just be doing a lot of merging to keep up with them :)

On 13/11/2013, at 1:13 PM, Shaun Jackman notifications@github.com wrote:

Portability patches sadly aren't generally being accepted into mxcl/homebrew. Feel free to petition them to hopefully change this policy.

—
Reply to this email directly or view it on GitHub.