Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generic): Preliminary support for 64-bit floats #116

Merged

Conversation

scottlaird
Copy link
Collaborator

To use this, declare a PDO in ethercat.xml with
halType="float-double-ieee".

This is currently completely untested. It compiles. That's all I can
promise.

Issue #115

@scottlaird
Copy link
Collaborator Author

scottlaird commented Jan 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @scottlaird and the rest of your teammates on Graphite Graphite

@scottlaird scottlaird marked this pull request as ready for review January 3, 2024 02:44
@MetalMusings
Copy link

Hi Scott, Hakan from the linuxcnc forum here. I'll add the diff against sittner's repo:
I attach the patch in a file
lcec-64bitfloatadded.patch

Basically the same as you, but I have the write of lreal when not well aligned in a record, as well. (At least that's I think what is
happening). Modeled after how it was done for float.
This has been running for days, with the right result, read and write. Not tested with lreal in a record, though.

To use this, declare a PDO in `ethercat.xml` with
`halType="float-double-ieee"`.

This is currently *completely* untested.  It compiles.  That's all I can
promise.

Issue #115
@scottlaird scottlaird force-pushed the 01-02-feat_generic_Preliminary_support_for_64-bit_floats branch from baf4e55 to cfc02b1 Compare January 7, 2024 04:01
@scottlaird
Copy link
Collaborator Author

I think I'm going to go ahead and merge this as-is, and we can revisit the float-in-record case, as well as potentially things like 53-bit-ints-in-doubles and other ways of abusing floats when someone has hardware that actually uses it. Any objection?

@scottlaird scottlaird added this pull request to the merge queue Jan 8, 2024
Merged via the queue into master with commit 10aa7b4 Jan 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants