fix: void register signal handler for SIG_CHILD #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
black-desk
force-pushed
the
black-desk/fix/wait
branch
from
971c35c
to
f36300f
Compare
black-desk
changed the title
black-desk
force-pushed
the
black-desk/fix/wait
branch
2 times, most recently
from
759fcf4
to
2365b90
Compare
BLumia
reviewed
May 19, 2023
black-desk
force-pushed
the
black-desk/fix/wait
branch
from
2365b90
to
1fdbd02
Compare
|
/+1 |
linuxdeepin/developer-center#4412 QProcess::execute will use waitid to get exit code of that process it starts. Register SIG_CHILD and wait all dead childs will break this mechanism, as QProcess will find out that there is no child to wait, and report this situation as a child process exit by crash. So I change the method of launch application to use a double fork, to start process and detach. Just as the way `QProcess` get this job done in its `startDetached` method. As a quick fix, I change the signature of `launch` method as no one use its return value currently. If this is need someday, we should use a pipe to let double forked child process report the return value and errno of its `exec` call. Signed-off-by: black-desk <me@black-desk.cn>
black-desk
force-pushed
the
black-desk/fix/wait
branch
from
1fdbd02
to
4d6ec82
Compare
justforlxz
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linuxdeepin/developer-center#4412
QProcess::execute will use waitid to get exit code of that process it
starts. Register SIG_CHILD and wait all dead childs will break this
mechanism, as QProcess will find out that there is no child to wait,
and report this situation as a child process exit by crash.
So I change the method of launch application to use a double fork, to
start process and detach. Just as the way
QProcessget this job donein its
startDetachedmethod.As a quick fix, I change the signature of
launchmethod as no one useits return value currently. If this is need someday, we should use a
pipe to let double forked child process report the return value and
errno of its
execcall.