Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme doesn't change #26

Closed
SiamSami opened this issue Jul 13, 2018 · 11 comments
Closed

Theme doesn't change #26

SiamSami opened this issue Jul 13, 2018 · 11 comments
Assignees

Comments

@SiamSami
Copy link
Contributor

SiamSami commented Jul 13, 2018

The theme of the file manager doesn't change even though theme of the other programs do.

Can you please fix it?

[EDIT] :
I am using Arch Linux. The version of the file manager is 1.7.
Also, I am trying to change the theme from deepin-settings and NOT from the file manager.

@BLumia
Copy link
Member

BLumia commented Jul 14, 2018

Did you means when you toggle the theme from the file manager's menu, it doesn't works?


btw, please always leave more details like which distro you are using, which version of dde-file-manager you are using and how to reproduce the issue so it can be very helpful for us to reproduce the bug and fix it.

@SalahAdDin
Copy link

@SiamSami do you have gnome-desktop too in your OS?

@BLumia
Copy link
Member

BLumia commented Jul 20, 2018

I am trying to change the theme from deepin-settings and NOT from the file manager.

Hi and we are not yet supported to make the theme follow the system setting for now, but we are planning to add this feature in the future.

btw, please post a new comment rather than edit the old post if you are adding information so we can get a notification about that. thx :)

@ghost
Copy link

ghost commented Sep 25, 2018

I am trying to change the theme from deepin-settings and NOT from the file manager.

Hi and we are not yet supported to make the theme follow the system setting for now, but we are planning to add this feature in the future.

btw, please post a new comment rather than edit the old post if you are adding information so we can get a notification about that. thx :)

@BLumia Any ETA on when all the deepin programs will follow the systems themes?

@BLumia
Copy link
Member

BLumia commented Sep 25, 2018

Any ETA on when all the deepin programs will follow the systems themes?

Not sure, probably when 15.8 or 15.9 got released, right after all other deepin app got dark theme support.

@wangjia12 wangjia12 self-assigned this Oct 25, 2018
@wangjia12
Copy link

@hualet @zccrs 你们有空自己做,不算在需求里面,开会讲的。

@xmine64
Copy link

xmine64 commented Feb 16, 2019

hi. i'm using deepin 15.9 on arch.
dark theme toggle with file manager works, but the change theme in settings not working.
it changes icons and cursor but not gtk theme.

@BLumia
Copy link
Member

BLumia commented Feb 17, 2019

hi. i'm using deepin 15.9 on arch.
dark theme toggle with file manager works, but the change theme in settings not working.
it changes icons and cursor but not gtk theme.

Yeah dde-file-manager's theme setting is independent with the one in system setting currently.

If you means changing theme from the system setting can not change the theme for gtk apps, then it's a different issue. Feel free to open a new issue at linuxdeepin/developer-center ;-)

@SiamSami
Copy link
Contributor Author

Since Deepin file manager doesn't support GTK themes, I think I should just close it then.

@ForeverZer0
Copy link

ForeverZer0 commented May 27, 2019

Pretty sure OP has the complaint that everyone else does about the theme for the file manager being hard-coded and not changing with the system's selected theme. For example, the file manager has either light or dark theme, there is nothing else.

To reproduce

  1. Install deepin and dde-file-manager
  2. Attempt to make file manager theme ANYTHING other than the default "light" or "dark", feel free to use any typical means necessary that don't involve building it from source.

Expected behavior

Changing system theme changes the appearance of the file manager.

What actually happens

Absolutely nothing, it just goes on looking different that the rest of OS.

This issue is rather critical and seems to be getting ignored. It seems to be the chief complaint with every review on the web, and is always answered with some (intentional?) confusion and misunderstanding when brought up to developers, as if they somehow unaware that this issue even exists.

@BLumia
Copy link
Member

BLumia commented May 27, 2019

Pretty sure OP has the complaint that everyone else does about the theme for the file manager being hard-coded and not changing with the system's selected theme. For example, the file manager has either light or dark theme, there is nothing else.

To reproduce

  1. Install deepin and dde-file-manager
  2. Attempt to make file manager theme ANYTHING other than the default "light" or "dark", feel free to use any typical means necessary that don't involve building it from source.

Expected behavior

Changing system theme changes the appearance of the file manager.

What actually happens

Absolutely nothing, it just goes on looking different that the rest of OS.

Well, the theme selection from control panel actually only control GTK application theme, DTK is not based on GTK so changing theme via that place will not change the DTK application appearance. The "Light" and "Dark" is also just a theme name, The list can be much more longer if you install more GTK themes:

image

This issue is rather critical and seems to be getting ignored. It seems to be the chief complaint with every review on the web, and is always answered with some (intentional?) confusion and misunderstanding when brought up to developers, as if they somehow unaware that this issue even exists.

Nope, actually we have plan about implement global DTK theme selection support in the future updates, but the priority is lower than what we current are working on. We mainly track our issue in Developer Center btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants