Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: border color issue #326

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix: border color issue #326

merged 1 commit into from
Jun 19, 2024

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Jun 18, 2024

adjust Inner border and outer border

Issue: linuxdeepin/developer-center#8342

18202781743
18202781743 previously approved these changes Jun 19, 2024
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

adjust Inner border and outer border

Issue: linuxdeepin/developer-center#8342
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 函数blendColorAlpha的命名不够明确,建议使用更具描述性的名称,如calculateBlendColorAlpha
  • blendColor属性中,使用了windowedFrameWindow.blendColorAlpha,但没有检查windowedFrameWindow是否已定义。
  • color属性的逻辑可能存在问题,特别是对于深浅模式切换时的颜色计算。
  • radius属性的计算似乎依赖于windowedFrameWindow,但当前的调用顺序没有反映这种依赖关系。

是否建议立即修改:

@kegechen
Copy link
Contributor

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Jun 19, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit f827815 into linuxdeepin:master Jun 19, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants