fix: don‘t mixed use pkgconfig and config.cmake #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All right about License Check! |
|
All right about README Check |
Log: find_package(DtkCore REQUIRED dtkcore) 的用法是不规范的 如果是用 pkg-config 的话是 pkg_search_module(DtkCore REQUIRED dtkcore) 用 find_package 应该是 find_package(Dtk REQUIRED Core Gui Widget) 这种 另外后面用的 DtkCore_INCLUDE_DIRS 也不是 DtkCoreConfig.camke 提供的，它提供的是 DTKCORE_INCLUDE_DIR（现在改成了 DtkCore_INCLUDE_DIR，旧的仍然保留），而且引入时就配置 include_directories 了，不用单独写。 而 DtkCore_INCLUDE_DIRS 正好是 cmake 的 pkg-config 模块设置的（用pkg_search_module才行）
|
All right about License Check! |
|
All right about README Check |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log: find_package(DtkCore REQUIRED dtkcore) 的用法是不规范的
如果是用 pkg-config 的话是 pkg_search_module(DtkCore REQUIRED dtkcore)
用 find_package 应该是 find_package(Dtk REQUIRED Core Gui Widget) 这种
另外后面用的 DtkCore_INCLUDE_DIRS 也不是 DtkCoreConfig.camke 提供的，它提供的是 DTKCORE_INCLUDE_DIR（现在改成了 DtkCore_INCLUDE_DIR，旧的仍然保留），而且引入时就配置 include_directories 了，不用单独写。
而 DtkCore_INCLUDE_DIRS 正好是 cmake 的 pkg-config 模块设置的（用pkg_search_module才行）