Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't override system CMAKE_EXE_LINKER_FLAGS and don't set -fPIE… #352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: don't override system CMAKE_EXE_LINKER_FLAGS and don't set -fPIE… #352

wants to merge 1 commit into from

Conversation

felixonmars
Copy link
Member

… for shared libraries

  • Append to CMAKE_EXE_LINKER_FLAGS instead of overriding it.
  • -fPIE is invalid for shared libraries. Removing it here fixes building for Arch. Please use --enable-default-pie for gcc instead of inserting PIE flags to every package.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: felixonmars

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felixonmars
fix: don't override system CMAKE_EXE_LINKER_FLAGS and don't set -fPIE…
b16acf2 
… for shared libraries

- Append to CMAKE_EXE_LINKER_FLAGS instead of overriding it.
- `-fPIE` is invalid for shared libraries. Removing it here fixes building for Arch. Please use --enable-default-pie for gcc instead of inserting PIE flags to every package.
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 22, 2023

TAG Bot

New tag: 5.10.39
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #398

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 5, 2024

TAG Bot

New tag: 5.10.40
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #407

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 10, 2024

TAG Bot

New tag: 5.10.41
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #411

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 16, 2024

TAG Bot

New tag: 6.0.6
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #412

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 19, 2024

TAG Bot

New tag: 5.10.42
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #415

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Feb 1, 2024

TAG Bot

New tag: 5.10.43
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #419

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Feb 5, 2024

TAG Bot

New tag: 5.10.44
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #420

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 1, 2024

TAG Bot

New tag: 5.10.45
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #425

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 13, 2024

TAG Bot

New tag: 5.10.46
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #429

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 12, 2024

TAG Bot

New tag: 6.0.7
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixonmars @deepin-ci-robot