Support RK3399?

[BiatuAutMiahn]

Can you add support for the Firefly-RK3399?

[linuxerwang]

What's its product ID?

[BiatuAutMiahn]

Where can I find that?

This is the product: http://en.t-firefly.com/en/firenow/Firefly_RK3399/

[cdslashetc]

The Firefly team already made a fork with RK3399 support https://github.com/T-Firefly/rkflashkit you can find more information in the Flash Image section of the wiki http://wiki.t-firefly.com/index.php/Firefly-RK3399/en

A good tip for Github in general is I find it's useful to click on the number to the right of Fork at the top of the page sometimes someone already made a fork with the features that you need or projects are abandoned but forked and continued by somebody else.

[linuxerwang]

They can create a pull request and I'll be happy to merge it.

…

On Sun, Apr 2, 2017 at 7:34 AM Jonathan Dill ***@***.***> wrote: The Firefly team already made a fork with RK3399 support https://github.com/T-Firefly/rkflashkit you can find more information in the Flash Image section of the wiki http://wiki.t-firefly.com/index.php/Firefly-RK3399/en — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADJsHrYZiq-NtqhmhqxcVbs-zOJhUnHCks5rr7HpgaJpZM4Mwth1> .

[cdslashetc]

Cool! I'll let them know.

They have Issues disabled on their repo, so I posted a message in the discussion forum, hopefully somebody will read it, would probably be more effective on the Chinese language forums which are more active, but I don't know Chinese yet.

[BiatuAutMiahn]

ya, that's why I made this issue. and I used they're fork, but unfortunately it does not work. it does not detect the RK3399, but the Linux Firmware Tool does just fine

[linuxerwang]

The key is this line: https://github.com/linuxerwang/rkflashkit/blob/master/src/rkflashkit/rktalk.py#L28

Someone has to tell me the product ID for RK3399, since I don't have any such devices.

[BiatuAutMiahn]

well, as a LOADER device it is 0x330C (for the PID). Sorry didn't know if u were talking about the VID/PID until i seen the source

[linuxerwang]

Added with commit dd68297.