Add support for user-provided bookmarks. #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nono
reviewed
Mar 16, 2018
config/routes.rb
Outdated
| @@ -18,16 +18,23 @@ | |||
| post :move | |||
| end | |||
| end | |||
| resources :liens, controller: "bookmarks", as: "bookmarks", except: [:index, :new, :create] do | |||
| member do | |||
| post :convert | |||
| end | ||
|
|
||
| add_index "bookmarks", ["cached_slug"], name: "index_bookmarks_on_cached_slug", using: :btree | ||
| add_index "bookmarks", ["owner_id"], name: "index_bookmarks_on_owner_id", using: :btree |
There was a problem hiding this comment.
I don't see the migration for this. Did you forget to include it in the commits?
There was a problem hiding this comment.
I did not write it. Now it's done :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this PR which adds support for a new content type in the form of bookmarks provided by the users. A bookmark is a link to a website along with a short description. Like other contents on the site this one can be commented, rated, tagged.
This commit provides the basics of the features. Registered users can submit and comment the bookmarks, anyone can read them.
Missing features include at least an atom feed and the forms for moderation.