New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for user-provided bookmarks. #220

Merged
merged 7 commits into from Mar 21, 2018

Conversation

Projects
None yet
2 participants
@j-jorge

j-jorge commented Mar 13, 2018

Please review this PR which adds support for a new content type in the form of bookmarks provided by the users. A bookmark is a link to a website along with a short description. Like other contents on the site this one can be commented, rated, tagged.

This commit provides the basics of the features. Registered users can submit and comment the bookmarks, anyone can read them.

Missing features include at least an atom feed and the forms for moderation.

@nono

Looks good to me

@@ -18,16 +18,23 @@
post :move
end
end
resources :liens, controller: "bookmarks", as: "bookmarks", except: [:index, :new, :create] do
member do
post :convert

This comment has been minimized.

@nono

nono Mar 16, 2018

Member

I think you don't need this route

This comment has been minimized.

@j-jorge
end
add_index "bookmarks", ["cached_slug"], name: "index_bookmarks_on_cached_slug", using: :btree
add_index "bookmarks", ["owner_id"], name: "index_bookmarks_on_owner_id", using: :btree

This comment has been minimized.

@nono

nono Mar 16, 2018

Member

I don't see the migration for this. Did you forget to include it in the commits?

This comment has been minimized.

@j-jorge

j-jorge Mar 18, 2018

I did not write it. Now it's done :)

@nono nono merged commit 56b0928 into linuxfrorg:master Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment