Don't save settings outside game folder

[HebaruSan]

Hi @linuxgurugamer,

A user spotted an "orphaned GameData" folder containing some of this mod's settings after running the game:

• https://forum.kerbalspaceprogram.com/index.php?/topic/209890-rp-1-on-linux-mint-21-cant-enter-space-centre-buildings-so-i-cant-start-a-game-solved/&do=findComment&comment=4179073

This happens because PatchInfo.destPath and PatchManager.CFG_DIR are relative paths, and a few of the places that use them do not prepend the game path (though some other spots do).

Now all places that use these variables prepend the game path, so these files and folders should save to the right folder.

[linuxgurugamer]

Look at where destPath is used, (line 86) it adds the KSPUtil.ApplicationRootPath there

[HebaruSan]

That's what I was referring to by "though some other spots do". I'm fixing code that does NOT use activePatchPath and therefore does NOT add KSPUtil.ApplicationRootPath.

[linuxgurugamer]

I'll review again when Im back on Wed

[HebaruSan]

Yeah, the code that I'm fixing has no connection to the code at line 86. Both start from destPath, which is a relative path, and manipulate it separately.

[linuxgurugamer]

@HebaruSan thanks. I did a fast look yesterday, missed the two you found.