Limit duplicate DLL warning to affected game versions #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I wasn't aware of that |
|
Update pushed to Spacedock, which is where CKAN gets it from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @linuxgurugamer,
The duplicate DLL bug was fixed in KSP 1.12.3, but current ZeroMiniAVC still complains to users as if it was present in current game versions. This causes headaches for users and other mod authors, see your forum thread and KSP-CKAN/NetKAN#9435.
This pull request adds a version check before the duplicate DLL checks are made. If the user is on KSP 1.12.0, 1.12.1, or 1.12.2 (in which duplicate DLLs crash the game), the warning appears as before. If they're on any other version (where duplicate DLLs don't crash the game), it doesn't appear.
Cheers!