Intuitive Maneuvers fix #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The text was showing as "- + Orb" but the button only increments.
Changed how the manager analysed the solver to find new maneuver nodes. The previous logic was not creating handlers, thereafter not applying the intuitive node logic when the gizmo was used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the Intuitive Maneuvers feature. The logic itself is intact, what I changed was another logic that detected new maneuver nodes to add the handler to override the stock behavior.
This PR should fix the issues mentioned in the forums and, maybe, also fix #14.
Bonus: Added a fix to the "+ Orb" button that was displaying as "- + Orb" while only incrementing.
This issue was in the English, Spanish and Russian translation, but not on the Chinese one.