Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile #576

Merged
merged 12 commits into from
Nov 24, 2023
Merged

Add Makefile #576

merged 12 commits into from
Nov 24, 2023

Conversation

yunkeying
Copy link
Contributor

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@helight
Copy link
Member

helight commented Nov 10, 2023

把 pr 和 issue 关联起来,你这个 pr 是针对那个 issue 的,关联进来,只要把 issue 地址贴到 pr 中,不过最好是把 pr 地址贴到 issue 中,这样就可以关联起来

@helight
Copy link
Member

helight commented Nov 10, 2023

  1. 这个项目没有加入到流水线中,做自动化
  2. 建议直接建立 mem_watcher 项目,page_fault作为其中一个功能

Copy link
Member

@helight helight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

这里 page_fault 还是一个独立的程序,并不是 mem_watcher程序的一部分,
下一步尽快建立mem_watcher程序

@chenamy2017 chenamy2017 merged commit 0609568 into linuxkerneltravel:develop Nov 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants