-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Makefile #576
Merged
Merged
Add Makefile #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunkeying
requested review from
helight,
LinkinPF and
chenamy2017
as code owners
November 10, 2023 06:23
把 pr 和 issue 关联起来,你这个 pr 是针对那个 issue 的,关联进来,只要把 issue 地址贴到 pr 中,不过最好是把 pr 地址贴到 issue 中,这样就可以关联起来 |
|
LinkinPF
reviewed
Nov 16, 2023
eBPF_Supermarket/Memory_Subsystem/mem_watcher/page_fault/page_fault.bpf.c
Outdated
Show resolved
Hide resolved
eBPF_Supermarket/Memory_Subsystem/mem_watcher/page_fault/page_fault.c
Outdated
Show resolved
Hide resolved
8 tasks
helight
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
这里 page_fault 还是一个独立的程序,并不是 mem_watcher程序的一部分,
下一步尽快建立mem_watcher程序
chenamy2017
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist