Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expect not installed on CI machine #23

Open
justincormack opened this issue Jul 15, 2017 · 6 comments
Open

expect not installed on CI machine #23

justincormack opened this issue Jul 15, 2017 · 6 comments

Comments

@justincormack
Copy link
Member

getty-containerd test needs inspect installed see linuxkit/linuxkit-logs@45fc7f5#diff-45abc448478fe2f1907cce047d595e85

We really need to dogfood the config with linuxit, so we can actually control it directly.

@justincormack
Copy link
Member Author

cc @talex5 @dave-tucker

@justincormack
Copy link
Member Author

Weirdly it passes on PRs and fails on master merges. Why?

@rn
Copy link
Member

rn commented Jul 15, 2017

I think for PRs we spin up a new VM and for master builds we may have a permanent VM running. I vaguely recall @dave-tucker mentioned something about a pretty beefy instance running...

@dave-tucker
Copy link
Member

Rolf is correct.
We have a fixed machine with 16 vCPUs, 104 GB RAM for PRs which could be a tad excessive IMHO. I think we should probably create machines on demand for master too and ideally with the same config used for PRs (albeit with secrets).
The process for updating the VM images used isn't documented but @talex5 has done this in the past.
I'm working on using LinuxKit for this but I'm waiting on my mount PR's to merge before I continue.

@talex5
Copy link
Contributor

talex5 commented Jul 17, 2017

expect (not inspect, but that seems to be what it wants from the error) is already installed on all build VMs. Perhaps it is trying to execute it on the CI host? In that case, it needs adding to the LinuxKit CI Dockerfile: https://github.com/linuxkit/linuxkit-ci/blob/master/Dockerfile

@dave-tucker
Copy link
Member

Closed via a042a1c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants