-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kernel build docs #2224
Update kernel build docs #2224
Conversation
Step X/29 : COMMAND | ||
---> b2a4a976d661 | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a few steps missing here. Mainly how to run menuconfig
and then how to copy .config
back to the source. They are kinda obvious, but given the rest of this addition is very detailed it's odd that the final steps are missing.
Also, this process will change quite a bit very soon (once https://github.com/linuxkit/linuxkit/tree/master/projects/kernel-config has been updated and merged)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh I think the stuff I added wasn't in here because it was obvious to you, now I left out the other stuff because it was obvious to me! Adding now.
this process will change quite a bit very soon
So... merge or leave?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the docs.
827d45d
to
b283420
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit, but otherwise LGTM
docs/kernels.md
Outdated
|
||
Unless you are building the config from scratch, you probably want to make small modifications to the existing config. | ||
|
||
1. Copy the appropriate config to the build location: `cp /src/kernel.config-<series> /linux/.config` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's already done by the previous Docker build step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Updated.
b283420
to
83eee51
Compare
@rn ok to merge? |
Signed-off-by: Avi Deitcher <avi@deitcher.net>
83eee51
to
c6b7b3c
Compare
nor sure why CI failed. hit the rebuild button |
Hmm, since it was only docs, maybe it is my Canadian accent? :-) |
The |
The only failure I see when hitting the "Previous state" link from the results page a few times is this log which is a goroutine panic in rtf itself: |
Oh, well in that case open an |
Was just doing it: linuxkit/rtf#23 |
Signed-off-by: Avi Deitcher avi@deitcher.net
- What I did
Updated the kernel build doc to describe:
menuconfig
vs direct editing- How I did it
Slack with @justincormack and @rn and then typed it all up!
- How to verify it
Read the docs. If they make sense, it works.
- Description for the changelog
Update kernel build docs with more detail on building modules and the kernel.
- A picture of a cute animal (not mandatory but encouraged)