Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kernel build docs #2224

Merged
merged 1 commit into from
Jul 17, 2017

Conversation

deitch
Copy link
Collaborator

@deitch deitch commented Jul 17, 2017

Signed-off-by: Avi Deitcher avi@deitcher.net

- What I did
Updated the kernel build doc to describe:

  • Difference between building external modules vs in-tree modules and options
  • How to build based on a modified config
  • How and when to use menuconfig vs direct editing
  • How to get a ready-to-build-kernel environment

- How I did it
Slack with @justincormack and @rn and then typed it all up!

- How to verify it
Read the docs. If they make sense, it works.

- Description for the changelog

Update kernel build docs with more detail on building modules and the kernel.

- A picture of a cute animal (not mandatory but encouraged)
Jabba

Step X/29 : COMMAND
---> b2a4a976d661
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few steps missing here. Mainly how to run menuconfig and then how to copy .config back to the source. They are kinda obvious, but given the rest of this addition is very detailed it's odd that the final steps are missing.

Also, this process will change quite a bit very soon (once https://github.com/linuxkit/linuxkit/tree/master/projects/kernel-config has been updated and merged)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh I think the stuff I added wasn't in here because it was obvious to you, now I left out the other stuff because it was obvious to me! Adding now.

this process will change quite a bit very soon

So... merge or leave?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the docs.

@deitch deitch force-pushed the updated-kernel-instructions branch from 827d45d to b283420 Compare July 17, 2017 10:47
Copy link
Member

@rn rn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, but otherwise LGTM

docs/kernels.md Outdated

Unless you are building the config from scratch, you probably want to make small modifications to the existing config.

1. Copy the appropriate config to the build location: `cp /src/kernel.config-<series> /linux/.config`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's already done by the previous Docker build step

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Updated.

@deitch deitch force-pushed the updated-kernel-instructions branch from b283420 to 83eee51 Compare July 17, 2017 11:01
@deitch
Copy link
Collaborator Author

deitch commented Jul 17, 2017

@rn ok to merge?

Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch deitch force-pushed the updated-kernel-instructions branch from 83eee51 to c6b7b3c Compare July 17, 2017 11:04
@rn
Copy link
Member

rn commented Jul 17, 2017

nor sure why CI failed. hit the rebuild button

@deitch
Copy link
Collaborator Author

deitch commented Jul 17, 2017

Hmm, since it was only docs, maybe it is my Canadian accent? :-)

@justincormack
Copy link
Member

The containerd-getty test has been a bit flaky. I think we should replace that with something smaller than redis (not sure if that was what failed). Created #2229

@justincormack justincormack merged commit 6079dfe into linuxkit:master Jul 17, 2017
@deitch deitch deleted the updated-kernel-instructions branch July 17, 2017 13:30
@ijc
Copy link
Contributor

ijc commented Jul 17, 2017

The only failure I see when hitting the "Previous state" link from the results page a few times is this log which is a goroutine panic in rtf itself:
fatal error: concurrent map iteration and map write

@justincormack
Copy link
Member

Oh, well in that case open an rtf issue

@ijc
Copy link
Contributor

ijc commented Jul 17, 2017

Was just doing it: linuxkit/rtf#23

@ijc ijc mentioned this pull request Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants