pkg/init: Mount /sys/fs/bpf #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why CI is failing, the error seems certainly unrelated: |
|
I wonder if I should update any of the examples, and if so, the question is - which ones? |
deitch
reviewed
May 6, 2020
Did you run the |
|
Nope, looks like you did not. Let's do that. |
errordeveloper
force-pushed
the
mount-sys-fs-bpf
branch
from
aa3a0f0
to
fff04cf
Compare
|
Looking better now. Image is almost pushed out. |
|
Image is out. |
|
@deitch is |
NOTE: This will be a shared mount, due to root being turned into a
shared with `MC_REC` set: `mount("", "/", "", rec|shared, "")`.
For some reason setting `shared` when mounting `/sys/fs/bpf` doesn't
work at all, perhaps that's just a kernel feature.
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
errordeveloper
force-pushed
the
mount-sys-fs-bpf
branch
from
fff04cf
to
86fb6ba
Compare
|
@deitch CI is getting greener 🎉 |
|
Yup. That last one takes a long time to run, can be 60+ minutes (lots of building OSes and running them and tearing them down). When it clears green, we can merge this in. |
deitch
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description for the changelog
pkg/init: mount /sys/fs/bpf (fix docker/for-mac#4454)