Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 99% of deprecated ioutil usage (src/cmd/linuxkit) #3842

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Remove 99% of deprecated ioutil usage (src/cmd/linuxkit) #3842

merged 1 commit into from
Oct 9, 2022

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 8, 2022

Signed-off-by: David Gageot david.gageot@docker.com

@thaJeztah thaJeztah mentioned this pull request Oct 8, 2022
Merged
thaJeztah
thaJeztah suggested changes Oct 8, 2022
View reviewed changes
Copy link
Contributor

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some files where you forgot to add the "io" to imports, and left a comment on formatting the comments (mostly a nit as these functions are not exported)

pkg/metadata/provider_gcp.go Outdated Show resolved Hide resolved
pkg/metadata/provider_gcp.go Outdated Show resolved Hide resolved
pkg/metadata/provider_vultr.go Outdated Show resolved Hide resolved
pkg/metadata/provider_digitalocean.go Outdated Show resolved Hide resolved
pkg/metadata/provider_hetzner.go Outdated Show resolved Hide resolved
pkg/metadata/provider_metaldata.go Outdated Show resolved Hide resolved
pkg/metadata/provider_openstack.go Outdated Show resolved Hide resolved
pkg/metadata/provider_scaleway.go Outdated Show resolved Hide resolved
@dgageot
Copy link
Contributor Author

dgageot commented Oct 9, 2022

Sorry for the mess...

@deitch
Copy link
Collaborator

deitch commented Oct 9, 2022

Again, I would prefer if we split out the changes to the CLI src/cmd/linuxkit and the ones to packages pkg/. Just better risk management and ability to roll back if we have issues.

@dgageot dgageot marked this pull request as draft October 9, 2022 08:21
@dgageot
Remove 99% of deprecated ioutil usage
7687de2 
Signed-off-by: David Gageot <david.gageot@docker.com>
@dgageot dgageot changed the title Remove 99% of deprecated ioutil usage Remove 99% of deprecated ioutil usage (src/cmd/linuxkit) Oct 9, 2022
@dgageot dgageot marked this pull request as ready for review October 9, 2022 11:34
@deitch deitch merged commit a3f3f56 into linuxkit:master Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah requested changes

@deitch deitch deitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dgageot @deitch @thaJeztah