Remove dead or redundant code (src/cmd/linuxkit) #3843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
force-pushed
the
remove-more-dead-code
branch
from
afe38fd
to
341091b
Compare
|
Can you split these into two, one for src/cmd/linuxkit and one for the packages? If we have any issues with the changes, it'll make it far simpler to track down. Shouldn't |
dgageot
force-pushed
the
remove-more-dead-code
branch
from
341091b
to
5d58062
Compare
dgageot
changed the title
deitch
reviewed
Oct 9, 2022
dgageot
force-pushed
the
remove-more-dead-code
branch
from
5d58062
to
9680d94
Compare
|
Needs a rebase |
Signed-off-by: David Gageot <david.gageot@docker.com>
dgageot
force-pushed
the
remove-more-dead-code
branch
from
9680d94
to
ac62571
Compare
deitch
approved these changes
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot david.gageot@docker.com