Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments #3845

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Fix comments #3845

merged 1 commit into from
Oct 9, 2022

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 8, 2022

Signed-off-by: David Gageot david.gageot@docker.com

Signed-off-by: David Gageot <david.gageot@docker.com>
Copy link
Contributor

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? The phrase "symlinks to x" has been in common use as long as I can remember (which I won't admit how far)

@dgageot
Copy link
Contributor Author

dgageot commented Oct 9, 2022

@deitch It's just that function comments in Go should start with the name of the function followed by a verb.
It's really a nit but here the function is Symlink and the comment starts with Symlinks.

@deitch
Copy link
Collaborator

deitch commented Oct 9, 2022

Oh from the go comments perspective? OK, sure, that makes sense.

@deitch deitch merged commit 8ef4fa3 into linuxkit:master Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants