Remove dead or redundant code (packages) #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deitch
reviewed
Oct 9, 2022
dgageot
force-pushed
the
remove-more-dead-code-pkg
branch
2 times, most recently
from
4bb3a62
to
59c8ccc
Compare
Signed-off-by: David Gageot <david.gageot@docker.com>
dgageot
force-pushed
the
remove-more-dead-code-pkg
branch
from
59c8ccc
to
39807bb
Compare
thaJeztah
reviewed
Oct 9, 2022
| @@ -108,7 +108,7 @@ func main() { | |||
| d := time.Date(int(t.tmYear+1900), time.Month(t.tmMon+1), int(t.tmMday), int(t.tmHour), int(t.tmMin), int(t.tmSec), 0, time.UTC) | |||
| log.Printf("Setting system clock to %s", d) | |||
| tv := syscall.Timeval{ | |||
| Sec: int64(d.Unix()), | |||
There was a problem hiding this comment.
Could this one have been for non-x86 or 32-bit arches? I know we have similar casts in other repositories (but if it's deliberate; we need to add a nolint comment with an explanation
There was a problem hiding this comment.
I am not sure. I think that as long as it is not complaining, let's leave it as is. If someone has an issue somewhere on a 32-bit arch, let's worry about it then.
deitch
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot david.gageot@docker.com