Faster image export #3853
Merged
Faster image export #3853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
True, we only ever call this to create a tar reader, but it is possible we might want to actually run it. Any reason not to make it a boolean parameter and pass it as |
|
@deitch No reason. I saw it was used only in that case. I can change that |
Creating the container without a network takes 50 to 80ms less. Signed-off-by: David Gageot <david.gageot@docker.com>
dgageot
force-pushed
the
faster-export
branch
from
ce0b564
to
4867802
Compare
|
@deitch Should be better now. Next time we have to add a flag to this function, it'll probably better to directly pass a |
deitch
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the container without a network takes 50 to 80ms less.
Signed-off-by: David Gageot david.gageot@docker.com