Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move rtf commands from GHA into make test; remove unused artifacts #3858

Merged
merged 1 commit into from Oct 24, 2022

Conversation

deitch
Copy link
Collaborator

@deitch deitch commented Oct 24, 2022

Signed-off-by: Avi Deitcher avi@deitcher.net

- What I did

  • eliminated unused gcp artifact hack in test/Makefile
  • added support for specifying test suites in make test
  • replaced all direct calls to rtf in GHA workflows with make test calls

This is worth it on its own. Once it is done, I will use matrix to create parallel packages tests, which should speed up CI.

- How I did it

Changes to the two Makefiles in ci.yaml

- How to verify it

CI. If it works, then nothing has broken.

- Description for the changelog

rtf call refactor

Signed-off-by: Avi Deitcher <avi@deitcher.net>
Copy link
Member

@rn rn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think we use GCP anymore

@rn rn merged commit 5200e52 into linuxkit:master Oct 24, 2022
@deitch deitch deleted the makefile-rtf-tests branch October 25, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants