Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when cannot get remote manifest in checking registry, that is just a … #3870

Merged
merged 1 commit into from Nov 9, 2022

Conversation

deitch
Copy link
Collaborator

@deitch deitch commented Nov 8, 2022

…sign that it does not exist there

Signed-off-by: Avi Deitcher avi@deitcher.net

- What I did

When checking if image is in registry for pkg build, it failed on errors, when it should treat errors as, "I could not find it there, so go ahead and build."

- How I did it

Change handling of if err != nil

- How to verify it

CI

- Description for the changelog

Proper registry error handling

…sign that it does not exist there

Signed-off-by: Avi Deitcher <avi@deitcher.net>
@the-maldridge
Copy link
Contributor

This appears to get past the initial error, but sshd still fails to build from source, so I'm curious what CI is trying to build.

@deitch
Copy link
Collaborator Author

deitch commented Nov 9, 2022

I have no issues building pkg/sshd from source, including if I make minor changes to the package to force a "dirty" build.

I am going to merge this in as it urgently fixes a breaking issue. If there is a separate issue - with build in general or pkg/sshd in particular - open a new issue on it please.

@deitch deitch merged commit 4f23407 into linuxkit:master Nov 9, 2022
@deitch deitch deleted the fix-registry-check-error-handler branch November 9, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants