Retain /lib/apk/db for SBOM tools #3913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deitch
approved these changes
Mar 13, 2023
deitch
requested changes
Mar 13, 2023
pkg/containerd/Dockerfile
Outdated
| @@ -12,3 +12,4 @@ COPY --from=containerd-dev /usr/bin/containerd /usr/bin/ctr /usr/bin/containerd- | |||
| COPY --from=alpine /usr/share/zoneinfo/UTC /etc/localtime | |||
| COPY --from=alpine /etc/init.d/ /etc/init.d/ | |||
| COPY etc etc/ | |||
| COPY lib/apk lib/apk/ | |||
There was a problem hiding this comment.
I think you meant this to be COPY --from=build /lib/apk /lib/apk
Same for the others
There was a problem hiding this comment.
@deitch updated PR with --from
This allows SBOM tools to look at /lib/apk/db/installed to determine which package versions are included in the container. This should probably be applied across all of the linuxkit containers. Signed-off-by: eriknordmark <erik@zededa.com>
eriknordmark
force-pushed
the
apk-db-installed
branch
from
556a914
to
b43002f
Compare
|
Let CI run. |
deitch
approved these changes
Mar 14, 2023
|
Done and merged. Give it about 10-15 minutes and new images should be pushed out automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This allows SBOM tools to look at /lib/apk/db/installed to determine which package versions are included in the container. This should probably be applied across all of the linuxkit containers.
- How I did it
Preserve /etc/apk and /lib/apk by copying it to the container
- How to verify it
Inspect the produced containers to check that they have /lib/apk/db/installed
- Description for the changelog
Retain /lib/apk/db for SBOM tools