Allow service restarts when using memlogd #3920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stijn Opheide <stijn@opheide.be>
stijnopheide
force-pushed
the
fix/service-restarts-with-memlogd
branch
from
7f2d890
to
247d919
Compare
deitch
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3918
Updated the init pkg to remove the file at the fifo log location if it exists. This replicates the behavior of os.Create for local log files which truncates the file if it exists.
Update the init container to the version of this PR and use it in
logging.ymlas specified in the issue #3918Allow service restarts when using memlogd