Main version binaries #3933
Merged
Main version binaries #3933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avi Deitcher <avi@deitcher.net>
Signed-off-by: Avi Deitcher <avi@deitcher.net>
deitch
force-pushed
the
main-version-binaries
branch
from
f4d1974
to
0cb961e
Compare
Signed-off-by: Avi Deitcher <avi@deitcher.net>
deitch
force-pushed
the
main-version-binaries
branch
3 times, most recently
from
87dc3e1
to
62d555f
Compare
Signed-off-by: Avi Deitcher <avi@deitcher.net>
deitch
force-pushed
the
main-version-binaries
branch
from
62d555f
to
3aeac87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Now that
GOPKGVERSIONis included as a build arg, update all of our binaries to include-X main.Version=<version>. Also need to update all of the downstream dependencies of all of those.No logic changes otherwise.
- How I did it
pkg/, updated the dependencies withscripts/update-component-sha.sh- How to verify it
CI is good
- Description for the changelog
All linuxkit binaries include their version as
main.Version, which other things can pick up.